Fix #14899: FP invalidPrintfArgType_float with _sprintf_s_l() - #8729
Open
ludviggunne wants to merge 5 commits into
Open
Fix #14899: FP invalidPrintfArgType_float with _sprintf_s_l() #8729ludviggunne wants to merge 5 commits into
ludviggunne wants to merge 5 commits into
Conversation
ludviggunne
force-pushed
the
14899-sprintf
branch
2 times, most recently
from
July 15, 2026 14:00
a956174 to
72718dd
Compare
This reverts commit b8b6c71b935c5eb1a39cbfbd063bd285331fd7ec.
ludviggunne
force-pushed
the
14899-sprintf
branch
from
July 27, 2026 11:52
72718dd to
5401d01
Compare
danmar
reviewed
Aug 3, 2026
|
|
||
| static int getMaxArgNo(const Library::Function *func) | ||
| { | ||
| const auto &checks = func->argumentChecks; |
Collaborator
There was a problem hiding this comment.
are you 100% sure that func will never be null here?
Collaborator
Author
There was a problem hiding this comment.
Yes, it's checked at the call site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.